[DO NOT REVIEW YET] bump retry count upon task initialization as opposed to failure#1366
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 201c0b76f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// If retry count already exceeds limit, mark as failed (recovery for stale state). | ||
| if (processing_part_entry.retry_count > max_retries) | ||
| { |
There was a problem hiding this comment.
The new stale-state recovery check only trips when retry_count > max_retries, so a part that has already consumed its last allowed retry (e.g. a node crashes after incrementing retry_count but before handlePartExportFailure can mark FAILED) will still be re-attempted. That yields an extra export attempt beyond the configured export_merge_tree_partition_max_retries, and can lead to repeated retries if the same crash repeats. Using >= here (and in the analogous scheduler check) would keep behavior consistent with the failure handler’s >= limit and avoid exceeding the configured cap in this crash/pending scenario.
Useful? React with 👍 / 👎.
|
Bumping the retry count and failing the task is no longer transactional as it the retry count is being bumped at the beginning. This means it is possible for a node to increase the retry count, hit some errors while trying to export and not be able to mark the status as failed. In that case, we'll have a task with retry_count >= max_retries, but still To mitigate that, during the discovery of new tasks, I check the status and retry_count. if retry_count >= max_retries and status is still pending, I assume it was the case above. But now I realized the following: maybe it is just in progress and not finished yet :) |
1 participant
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Related to #1278
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: